I have never owned a single scope, from the cheapest to the most expensive, that had a zero holding problem (not counting the time I accidentally dropped a rifle scope-first on a big rock from a height of about 5 feet -- the rear bell was (and still is) bent, and yes, I had to re-zero after that, and yes, it's held zero since then -- the scope in question is a $50 Bushnell Sportsman, of all things to boot).
I have, however, owned a surprising number of rifles that would not "hold zero" and/or needed a LOT of tedious work before they would shoot consistently. I tend to think that there is lots of blame thrown at optics that really should be thrown at the rifles themselves (especially those who are a fan of wood stocks, that don't take the time to have them properly (and heavily) glass beded).