Doesn't fit my G21sf, not worth a damn. I just use a master combo trigger lock. The trigger guard is just way too big. I'm pretty sure I could still activate the trigger with it on, if you can put it on better than me, good for you, but it doesn't work at all for me. I do use those little ones though, on all my other restricted firearms.