FWIW:
IMO a "real" WW2 P38 is really inching up in value to the point I wouldn't want to shoot one if I had it. The nice ones are all collectors pieces now it seems.. (at least in the U.S.).
If you want a P38 to just shoot and enjoy I recommend the P1 that replaced it. The P1 is basically a P38, but with alloy frame. The early P1-s DID have a problem with frame crack issues, under severe use conditions, until the "fat slide conversion" was done, which in effect was a heavier slide, and included a hex bolt, strengthing the frame.
You can find the "good" P1's all over the place, and the prices, IMO, are still low. My P1 is surprisingly accurate at 15 yards or less, and a pleasure to shoot. I think the current batch of P1's, if you get one with the hex bolt, are wonderful firearm bargains.
I only paid $199.00 (US) for the P1 pictured, and that included a used holster, & extra new Walther magazine.
Best Wishes,
J. Pomeroy